Added Story for AddressMotionToVacateView
#14777
Conversation
(shows how to use decorators for router & redux)
|
|
||
| const Template = () => <AddressMotionToVacateView />; | ||
|
|
||
| export const Basic = Template.bind({}); |
There was a problem hiding this comment.
This (setting up a template once and then basing all stories off of it) is the recommended syntax for stories in Storybook 6.x. While it isn't particularly useful in a case with only a single story, I used it here for example purposes.
| title: | ||
| 'Queue/Motions to Vacate/Judge Address Motion to Vacate/AddressMotionToVacateView', | ||
| component: AddressMotionToVacateView, | ||
| decorators: [RouterDecorator, ReduxDecorator], |
There was a problem hiding this comment.
You can specify as many decorators as you want. Each will simply wrap the next.
|
Code Climate has analyzed commit e3ccc16 and detected 0 issues on this pull request. View more on Code Climate. |
| }; | ||
|
|
||
| const RouterDecorator = (storyFn) => ( | ||
| <StaticRouter |
There was a problem hiding this comment.
There's a chance that using MemoryRouter here might actually be better; StaticRouter works fine here since we have only one story and don't use react-router for anything other than grabbing the matched params.
| appealDetails: { | ||
| [appealId]: appeal, | ||
| }, | ||
| amaTasks: { |
There was a problem hiding this comment.
I kept this seed data to the bare minimum necessary to render the component in the story. This should properly contain the whole task tree.
There was a problem hiding this comment.
There might be some seed data missing, I'm getting an error for the partial grant option (will upload a screenshot on the PR).
|
@jcq This mostly looks great! I'm getting this error when I select the partial grant option. |
(fixes issue when choosing partial grant disposition)
@leikkisa Updated with the additional seed data necessary to avoid that issue! |
Generated by 🚫 Danger |
jcq
added
the
Ready-to-Merge
Description
This adds a story for
AddressMotionToVacateViewcomponent as a way to demonstrate how to use decorators to wrap stories when components depend on things likereact-routerorredux.Acceptance Criteria
AddressMotionToVacateViewrenders properly